Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPV6 follow-up #776

Merged
merged 2 commits into from
Jun 3, 2024
Merged

IPV6 follow-up #776

merged 2 commits into from
Jun 3, 2024

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented May 31, 2024 •
edited
Loading

Reverts part of #742

Only leaves the relevant part which was to switch to the URL(String,String,String,String) constructor.

The change from localhost to ip caused some test failures in Kubernetes context (It is invalid to provide an IP address as part of an ingress host name, and this was derived from the Jenkins URL)

Testing done

Added a test verifying in ipv6-only context that you can indeed start a Jenkins instance providing an IPv6 IP.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe
IPV6 follow-up
589639c 
Reverts part of jenkinsci#742

Only leaves the relevant part which was to switch to the
URL(String,String,String,String) constructor.

The change from localhost to ip caused some test failures in Kubernetes
context (It is invalid to provide an IP address as part of an ingress
host name)
@Vlatombe Vlatombe mentioned this pull request May 31, 2024
Merged
@jglick jglick added the bug label May 31, 2024
jglick
jglick approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think? I guess you ran at least the new test in an IPv6 VM? Do we have any way of verifying that this does not regress some random plugin’s tests?

src/main/java/org/jvnet/hudson/test/RealJenkinsRule.java Outdated Show resolved Hide resolved
@Vlatombe @jglick
Update src/main/java/org/jvnet/hudson/test/RealJenkinsRule.java
06fe714 
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@Vlatombe
Copy link
Member Author

the new test in an IPv6 VM

I lack the setup to do that, but in my experience running with -Djava.net.preferIPv4Stack=false -Djava.net.preferIPv6Addresses=true behaves pretty much the same.

@jglick jglick requested a review from imonteroperez May 31, 2024 15:22
@jglick jglick merged commit 29bbb2e into jenkinsci:master Jun 3, 2024
14 checks passed
@Vlatombe Vlatombe deleted the ipv6-follow-up branch June 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@imonteroperez imonteroperez imonteroperez approved these changes

@raul-arabaolaza raul-arabaolaza raul-arabaolaza approved these changes

@amuniz amuniz amuniz approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Vlatombe @jglick @imonteroperez @raul-arabaolaza @amuniz @timja