Add option to bump baseline of rjrinit plugin default to true #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the version of Jenkins used by RealJenkinsRuleInit has detached plugins in the version of Jenknis used for the test then this can uncessescarily pull in detached plugins. In most cases this is harmless, but in some cases these plugins may be prevented from running under the test (e.g. testing FIPS and one of the detached plugins like eddsa is not FIPS complaint and blocks startup). The plugin itself has limited exposure to the Jenkins api (via hudson.plugin.Plugin and RealJenkinsRule$Init2). Code running from the plugin tests inside RealJenkinsRule use the uberClassloader and if the plugin was targetting a lower core (where the dependencies have been deteached, they should still be included as this change only affects the version of the RealJenkinsRuleInit plugin.
6 tasks
jtnord
added a commit
to jtnord/bom
that referenced
this pull request
Jun 5, 2024
jglick
reviewed
Jun 5, 2024
| * The intended use case of this is to prevent any detached plugins being dragged in when they would not normally be. | ||
| * @param updateRealJenkinsRuleInitPluginBaseline {@code false} to skip updating the plugin, {@code true} (the default) to update the baseline. | ||
| */ | ||
| public RealJenkinsRule updateRealJenkinsRuleInitPluginBaseline(boolean updateRealJenkinsRuleInitPluginBaseline) { |
There was a problem hiding this comment.
Or just do it unconditionally? If there are no known problems, why even offer the option to not do it?
6 tasks
|
closing in favor of #782 |
jtnord
deleted the
add-option-to-bump-baseline-of-rjrinit-plugin-default-to-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#780 (comment)
to get an incremental build that can then be used in the bom
jenkinsci/bom#3284
Testing done
Submitter checklist