Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set maven libs according to consumers #440

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 3, 2023

https://groups.google.com/g/jenkinsci-dev/c/Xua30fqoqZc

downgrade libraries and add dependabot exclusion

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes

<maven-plugin-tools.version>3.8.1</maven-plugin-tools.version> <!-- extra work needed when https://issues.apache.org/jira/browse/MPLUGIN-449 is fixed -->
<plexus-containers.version>2.1.1</plexus-containers.version>
<aether.version>1.1.0</aether.version>
</properties>

<prerequisites>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not strictly necessary - but as we do not know if we use an api that was only introduced in this version it prevents random blow ups in consumers.

@jtnord jtnord requested review from olamy and basil March 3, 2023 17:44
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil
Copy link
Member

basil commented Mar 4, 2023

This isn't the only Maven plugin maintained by the Jenkins core team. For consistency, maven-jellydoc-plugin,maven-stapler-plugin, incrementals-maven-plugin, access-modifier-checker, and bridge-method-injector need the same treatment.

@basil
Copy link
Member

basil commented Mar 9, 2023

For the task to be fully complete, all of the above PRs (including this PR) should be released, and consumers updated to adopt those releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants