enable cd #484
enable cd #484
Conversation
pom.xml
Outdated
| @@ -34,7 +34,7 @@ | |||
| <modelVersion>4.0.0</modelVersion> | |||
| <groupId>org.jenkinsci.plugins</groupId> | |||
| <artifactId>pipeline-model-parent</artifactId> | |||
| <version>${revision}${changelist}</version> | |||
| <version>${revision}.${changelist}</version> | |||
There was a problem hiding this comment.
per @jtnord 's suggestion, going with a 2.{revision}.{changelist}
There was a problem hiding this comment.
whilst you do not care about semver having a prefix instead of just starting with a huge number means we can more easily to compatable-since (can just bump the first number and say since 3.0 without having to constantly update it if something else gets merged first) and well these numbers are meaningless anyway so have a 2.whatever is no worse than otherwise, and allows us to have the compatable-since should it ever be needed (so is a good general practice in my opinion).
ie there is a pro with no noticeable drawback as far as I can see, as this gives us more flexibility to do things in the future.
There was a problem hiding this comment.
No major drawback, just extra stuff in the version string before what you need to pay attention to, and inconsistency with other plugins.
In the rare case that a compatibleSince is added or updated, this is easily supported: leave that version TODO in the PR, and when merging, do so by hand and make the merge commit use $(git rev-list --count master) + 1.
There was a problem hiding this comment.
this is easily supported
but requires a special flow - which I think is good to avoid in general?
.mvn/maven.config
Outdated
| @@ -1,2 +1,3 @@ | |||
| -Pconsume-incrementals | |||
| -Pmight-produce-incrementals | |||
| -Dchangelist.format=%d.v%s | |||
|
build failed as other properties need to be updated. or we just change the version to be |
| @@ -1,3 +1,3 @@ | |||
| -Pconsume-incrementals | |||
| -Pmight-produce-incrementals | |||
| -Dchangelist.format=%d.v%s | |||
| -Dchangelist.format=2.%d.v%s | |||
There was a problem hiding this comment.
Standard
| -Dchangelist.format=2.%d.v%s | |
| -Dchangelist.format=%d.v%s |
suffices IMO.
Enable cd
see also: jenkins-infra/repository-permissions-updater#2324