-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BOM and dependabot #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several mistakes.
<relativePath /> | ||
</parent> | ||
|
||
<artifactId>ssh-agent</artifactId> | ||
<version>1.21-SNAPSHOT</version> | ||
<version>${revision}${changelist}</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you use mvn incrementals:incrementalify
? You forgot to commit the .mvn/
directory if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing .mvn/extensions.xml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add that one file instead of commenting 2y old already merged PR ;-)
At the same time, might be just as well good to consider adding this file globally to all repositories under /jenkinsci org - I don't think it would harm them even if they're not using incrementals at the moment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add that one file
Already done in #85.
consider adding this file globally to all repositories
Could, but probably more confusing than helpful, since mvn incrementals:incrementalify
expects to add it.
addressed, I think (use of force pushes makes it hard to tell what changed since last review)
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@jglick thanks for help on this. What's next? Iis the As a contributor, I'm just wondering if we can speed up the PR merging process somehow as it's not clear what happens here next. |
POM |
@MRamonLeon any thoughts? |
@MRamonLeon, @jglick ping again 🙏 |
I don't see any reason to release these changes. Do you need it for any reason? Thank you for your contribution @warden |
@MRamonLeon thanks for acting on this. No, this one is not needed to be released, more important is #30. |
No description provided.