Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation from Wiki to GitHub #53

Merged
merged 7 commits into from
Dec 11, 2019
Merged

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Nov 10, 2019

CHANGELOG.md Outdated
## Version 1.20 (Jul 29, 2019)

- [JENKINS-33217](https://issues.jenkins-ci.org/browse/JENKINS-33217) Log a warning when additional parameters are passed into \`DescribableModel\` objects, such as Pipeline steps, since these parameters are currently being ignored.
- Internal - Update parent pom ([PR-46](https://github.com/jenkinsci/structs-plugin/pull/46){.external-link}) and fix unit tests ([PR-50](https://github.com/jenkinsci/structs-plugin/pull/50){.external-link})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to strip all the {.external-link} tags. The wiki markdown converter unfortunately leaves all of those in place.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@car-roll car-roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some formatting cleanup and maybe adding a few shields

zbynek and others added 2 commits November 13, 2019 19:25
@zbynek
Copy link
Contributor Author

zbynek commented Nov 13, 2019

@car-roll thanks! I applied your suggestions.

@oleg-nenashev
Copy link
Member

@car-roll Hi. Would it be possible to get it released?

@car-roll
Copy link
Contributor

@oleg-nenashev I think so. Let me just check if there is another PR we can get in.

@car-roll car-roll merged commit 6271388 into jenkinsci:master Dec 11, 2019
@car-roll
Copy link
Contributor

@oleg-nenashev I can go ahead a cut a release for this. I was just wondering is there any particular reason we wanted this released now with just wiki migration?

@timja
Copy link
Member

timja commented Jan 29, 2021

Shall we release this @car-roll?

it's the most popular plugin that the migration hasn't been completed for

@car-roll
Copy link
Contributor

car-roll commented Feb 5, 2021

@timja 1.21 has now been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants