-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move documentation from Wiki to GitHub #53
Conversation
CHANGELOG.md
Outdated
## Version 1.20 (Jul 29, 2019) | ||
|
||
- [JENKINS-33217](https://issues.jenkins-ci.org/browse/JENKINS-33217) Log a warning when additional parameters are passed into \`DescribableModel\` objects, such as Pipeline steps, since these parameters are currently being ignored. | ||
- Internal - Update parent pom ([PR-46](https://github.com/jenkinsci/structs-plugin/pull/46){.external-link}) and fix unit tests ([PR-50](https://github.com/jenkinsci/structs-plugin/pull/50){.external-link}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to strip all the {.external-link}
tags. The wiki markdown converter unfortunately leaves all of those in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting cleanup and maybe adding a few shields
Co-Authored-By: Carroll Chiou <cchiou@cloudbees.com>
@car-roll thanks! I applied your suggestions. |
@car-roll Hi. Would it be possible to get it released? |
@oleg-nenashev I think so. Let me just check if there is another PR we can get in. |
@oleg-nenashev I can go ahead a cut a release for this. I was just wondering is there any particular reason we wanted this released now with just wiki migration? |
Shall we release this @car-roll? it's the most popular plugin that the migration hasn't been completed for |
@timja 1.21 has now been released |
See https://issues.jenkins-ci.org/browse/WEBSITE-637