Fix tests. #53
Merged
Fix tests. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Fixes #42
PHPUnit's mock builder's
->setMethod()has been replaced with->addMethod()in PHPUnit 10. Unfortunately it is being deprecated and removed without replacement in PHPUnit 12, at which time the test will need to be written differently to accommodate for that. Further,->getMockBuilder()is also being deprecated.I'm leaving the deprecated version in place, thinking it will get things moving quickly, allowing for more time and research down the road as to how the test needs to be restructured in PHPUnit 12.
sebastianbergmann/phpunit#5320
sebastianbergmann/phpunit#5754
sebastianbergmann/phpunit#5755
sebastianbergmann/phpunit#3985
PS: I believe the StyleCI issue is something that needs to be resolved within StyleCI, not sure as I don't use that service, and also do not see a specific configuration file within this repo.