Allow ignoring directories using non-negated string matchers #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks magnifico |
jergason
added a commit
that referenced
this pull request
Oct 28, 2015
Allow ignoring directories using non-negated string matchers
|
@Ajedi32 I just release 1.3.0. Thank you for all of your help! |
|
Awesome, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem created as a side effect of #20, while still solving the original issue, #16. It works by allowing string-based matchers to ignore directories, except when those matchers are negated (preceded by a
!), in which case they only apply to files.Let me know if this is something you want or not. After you decide whether to accept or reject this PR, I'd appreciate it if you'd cut a release so that we can use some of the recently added features from this library in Metalsmith.
If you decide to reject this PR though, the release would definitely have to be v2.0 as per SemVer, since you'd be removing the ability to ignore entire directories with string matchers. Even with this PR there have technically been breaking changes in
recursive-readdir's behavior, but you could probably get away with calling them a minor fix in that case, sincerecursive-readdir's previous handling of negated matchers wasn't particularly useful anyway.