Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimatch. #45

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Bump minimatch. #45

merged 1 commit into from
Feb 15, 2017

Conversation

wtgtybhertgeghgtwtg
Copy link
Contributor

No description provided.

@jergason
Copy link
Owner

jergason commented Feb 5, 2017

Thanks for the pr @wtgtybhertgeghgtwtg! Is there a specific reason to bump minimatch?

@wtgtybhertgeghgtwtg
Copy link
Contributor Author

Deduping, mostly. For create-react-app on yarn, the version recursive-readdir is using, minimatch@3.0.2, is being hoisted above the most common version minimatch@3.0.3; as such, there six or so duplicate copies of minimatch@3.0.3 in node_modules. yarn is planning on working on their hoister algorithm, but this would be a quicker solution for this case. If you bump to "minimatch": "3.0.3", or use a version range, it can dedupe.

@jergason jergason merged commit b6de264 into jergason:master Feb 15, 2017
@wtgtybhertgeghgtwtg
Copy link
Contributor Author

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants