Fixing issue with broken symlinks #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When traversing a directory containig broken symbolic links, said links throw error before we have a chance to ignore them, which we might want to. Solution: When encountering error code `ENOENT` make `lstat` call which doesn't fail on broken links due to not following them. It is up to the user then to check if he needs to ignore this particular link via ignore function or pattern. Fixes jergason#42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When traversing a directory containig broken symbolic links, said links
throw error before we have a chance to ignore them, which we might want
to.
Solution:
When encountering error code
ENOENTmakelstatcall which doesn'tfail on broken links due to not following them. It is up to the user
then to check if he needs to ignore this particular link via ignore
function or pattern.
Fixes #42