-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commmit - enhance docs for keybinding 'c' for local branch #3046
commmit - enhance docs for keybinding 'c' for local branch #3046
Conversation
smangels
commented
Oct 2, 2023
- closes Branches - switch branch to previous one #3030
- mention that it supports '-'
- fix documentation and builtin help
- closes jesseduffield#3030 - mention that it supports '-' - fix documentation and builtin help
I don't understand what this addition means, so probably needs to be worded differently. |
I've added what we've talked about in the PR, explaining that the "checkout" local branch dialog supports the '-' as well. |
Aha, I see. Maybe reword to Generally i just hit |
It's not that weird if you look at it from the |
Yep, for sure. But when using lazygit I'm generally not thinking in git CLI terms, which is why I use the down-space method instead |
Given that we're considering changing the default to sort branches by commit date rather than checkout recency, it would be good to have a committed key for this. The question is: what key? Not at my keyboard right now but Ctrl+c could work if it's not already taken |
I've adjusted the text according to received review comments. Personally I've assigned the dash to switching when being located in "local branch" scope. |
Good question, the distance from CTRL key would be worth considering as well. Words worth considering are
and derive characters from them? |
Very subjective, but I use the "`" key for "last" things in my own keyboard schema. I think this comes from macOS' cmd-` for window switching.. |
Backtick currently toggles tree mode in a files view. I can imagine in future having a tree mode in the branches view where e.g. branches prefixed with I'm leaning towards '-'. There's a chance somebody will press it in the attempt to shrink the current window but I do think it makes a lot of sense as the keybinding given that it's the argument you pass to |
(Also it just occurred to me that my earlier suggestion of ctrl+c makes absolutely no sense because that's the universally understood way of quitting a terminal application. One day I'll stop publicly embarrassing myself haha) |
No big deal - and it is used for copying selected text as well. So mhm, maybe not the best choice. But good that we managed to get rid of one choice at least. |
If nobody objects I say we go with '-' |
Thanks @smangels ! |
This was forgotten in #3046.