Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MacOS default path misspelling #3148

Merged

Conversation

zeromask1337
Copy link
Contributor

  • PR Description

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@mark2185 mark2185 added the docs label Dec 7, 2023
@mark2185 mark2185 merged commit ccb1ee0 into jesseduffield:master Dec 7, 2023
12 of 13 checks passed
@mark2185
Copy link
Collaborator

mark2185 commented Dec 7, 2023

Thank you for the contribution! :)

@stefanhaller
Copy link
Collaborator

Hm, I think this is actually wrong. The backslash is not technically part of the path; it's only needed when you want to copy/paste the path into a terminal, without putting quotes around it. But that's a technicality of the shell, it has nothing to do with the path itself. Proof: open TextEdit, type Command-O, then type Command-Shift-G (for "go to path"), and then paste the path into the text field there. This doesn't work with the backslash, but it does without.

I think the real problem that we should address is that people are trying to copy/paste the path into their terminal in the first place to edit the config file. There's no need to do that, it's much easier to fire up lazygit and type "1 e" to edit it. We should document this more prominently.

@mark2185
Copy link
Collaborator

mark2185 commented Dec 7, 2023

Ah, my reasoning was that people would try to copy and paste it, but given that my go-to destination was the terminal, it made sense to add the backslash.

Especially since editing the config through 1 e doesn't allow me to iterate on e.g. writing a custom command, I opt out for opening the config in one terminal, and launching (and subsequently) restarting lazygit in another.

@stefanhaller
Copy link
Collaborator

Ah, workflows. 😄 When I type 1 e the file opens in VS Code, so it doesn't block the terminal.

Yeah, but whatever; if this helps people, fine. 😄

@zeromask1337
Copy link
Contributor Author

@stefanhaller I understand your take, but from user perspective my first thought was to copy it and edit in the terminal. I think I'm not the only one into it, considering your user base (devs, terminal and nvim users). I don't think there are many people that use graphic interface to edit config file for terminal app :)

P.S thanks for 1 e shortcut, didn't know about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants