Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NixOs installation instructions to README.md #3249

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

rsniezek
Copy link
Contributor

Extend README.md with instructions on how to try and install the lazygit on NixOs.

  • PR Description
    Just README.md update, no code changes.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@rsniezek
Copy link
Contributor Author

@jesseduffield Feedback would be apprecieated, thank you!

@karimkhaleel
Copy link
Contributor

From my limited knowledge of nix and NixOS, this checks out.

@stefanhaller
Copy link
Collaborator

OK, thanks. I'm happy to merge this, but please don't merge master into your branch. This creates a messy git history that we don't want here. Rebase onto master instead.

(It's not possible to fix this now within lazygit because it insists on using the --rebase-merges option when you rebase, but you can fix it on the command line by saying git rebase --no-rebase-merges master.)

@rsniezek rsniezek force-pushed the patch-1 branch 2 times, most recently from 8fd07f0 to 9c006bf Compare March 19, 2024 11:27
@rsniezek
Copy link
Contributor Author

rsniezek commented Mar 19, 2024

OK, thanks. I'm happy to merge this, but please don't merge master into your branch. This creates a messy git history that we don't want here. Rebase onto master instead.

(It's not possible to fix this now within lazygit because it insists on using the --rebase-merges option when you rebase, but you can fix it on the command line by saying git rebase --no-rebase-merges master.)

Done. Added also the nix-flake enabled way to the readme. Cheers!

Extend README.md with instructions on how to try and install
the lazygit on NixOs.
@stefanhaller
Copy link
Collaborator

Nice, thanks. I took the liberty of force-pushing again to remove a trailing space (I'm picky about things like this...)

@stefanhaller stefanhaller merged commit fadc289 into jesseduffield:master Mar 19, 2024
13 of 14 checks passed
@rsniezek
Copy link
Contributor Author

Nice, thanks. I took the liberty of force-pushing again to remove a trailing space (I'm picky about things like this...)

No issue, your playground, your rules :)

Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants