Skip to content

Commit

Permalink
CRAN resubmission
Browse files Browse the repository at this point in the history
* Documentation fixes for CRAN checks.
  • Loading branch information
jessesadler committed Mar 21, 2023
1 parent b6eb010 commit ac843a1
Show file tree
Hide file tree
Showing 14 changed files with 59 additions and 3 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@
^cache$
^\.github$
^cran-comments\.md$
^CRAN-SUBMISSION$
3 changes: 2 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: debkeepr
Title: Analysis of Non-Decimal Currencies and Double-Entry Bookkeeping
Version: 0.1.0
Version: 0.1.1
Authors@R:
person("Jesse", "Sadler", , "jrsadler@icloud.com", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0001-6081-9681"))
Expand Down Expand Up @@ -33,6 +33,7 @@ Suggests:
igraph,
knitr,
rmarkdown,
roxygen2,
scales (>= 1.1.0),
testthat (>= 3.1.3)
VignetteBuilder:
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# debkeepr 0.1.1

- Documentation fixes for CRAN checks.

# debkeepr 0.1.0

- Prep for CRAN release.
- Transaction functions now return a data.frame if input is data.frame.
- Make all tests self-sufficient.
Expand Down
2 changes: 2 additions & 0 deletions R/arithmetic.R
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#' @param x,y Vectors.
#' @param op Arithmetic operation.
#' @param ... For future expansion
#' @returns A `deb_lsd`, `deb_tetra`, `deb_decimal` or `numeric` vector
#' depending on the inputs and arithmetic operator.
#' @name arithmetic
NULL

Expand Down
1 change: 1 addition & 0 deletions R/comparison.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#' Equality and comparison
#' @param x A deb_lsd vector.
#' @param ... Arguments passed on to further methods.
#' @returns A data frame or numeric vector to be used for comparison.
#' @name comparison
NULL

Expand Down
6 changes: 5 additions & 1 deletion R/debkeepr-package.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ NULL
#' @name %<-%
#' @rdname multi-assign
#' @keywords internal
#' @returns Invisibly returns `value`.
#' @export
#' @importFrom zeallot %<-%
#' @usage x \%<-\% value
Expand All @@ -23,14 +24,17 @@ NULL

#' Pipe operator
#'
#' See \code{magrittr::\link[magrittr]{\%>\%}} for details.
#' See \code{magrittr::\link[magrittr:pipe]{\%>\%}} for details.
#'
#' @name %>%
#' @rdname pipe
#' @keywords internal
#' @export
#' @importFrom magrittr %>%
#' @usage lhs \%>\% rhs
#' @param lhs A value or the magrittr placeholder.
#' @param rhs A function call using the magrittr semantics.
#' @return The result of calling `rhs(lhs)`.
NULL

#' Tidy eval helpers
Expand Down
2 changes: 2 additions & 0 deletions R/mathematics.R
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ trunc.deb_lsd <- function(x, ...) {
#' @param .fn A mathematical function from the base package.
#' @param .x A vector.
#' @param ... Additional arguments passed to `.fn`.
#' @returns A `deb_lsd` vector.
#' @export
vec_math.deb_lsd <- function(.fn, .x, ...) {
# Implement sum to allow various types of deb-style vectors in ...
Expand Down Expand Up @@ -332,6 +333,7 @@ trunc.deb_tetra <- function(x, ...) {
#' @param .fn A mathematical function from the base package.
#' @param .x A vector.
#' @param ... Additional arguments passed to `.fn`.
#' @returns A `deb_tetra` vector.
#' @export
vec_math.deb_tetra <- function(.fn, .x, ...) {
# Implement sum to allow various types of deb-style vectors in ...
Expand Down
16 changes: 16 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
## Resubmission

There are currently no references describing the methods in the package. I am currently working on writing a methods paper and will include it in a future update.

This is a resubmission. In this version I have:

* Added \value to the following .Rd files:
* arithmetic.Rd
* comparison.Rd
* multi-assign.Rd
* pipe.Rd
* vec_math.deb_lsd.Rd
* vec_math.deb_tetra.Rd

* I have added \arguments to pipe.Rd

## R CMD check results

0 errors | 0 warnings | 3 note
Expand Down
4 changes: 4 additions & 0 deletions man/arithmetic.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions man/comparison.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions man/multi-assign.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion man/pipe.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions man/vec_math.deb_lsd.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions man/vec_math.deb_tetra.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ac843a1

Please sign in to comment.