Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jest-matcher-utils): fix link #12072

Merged
merged 2 commits into from
Nov 25, 2021
Merged

docs(jest-matcher-utils): fix link #12072

merged 2 commits into from
Nov 25, 2021

Conversation

mrienstra
Copy link
Contributor

Minor, link to src/index.ts was broken

Minor, link to `src/index.ts` was broken
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #12072 (51a7900) into main (42b020f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12072   +/-   ##
=======================================
  Coverage   68.88%   68.89%           
=======================================
  Files         324      324           
  Lines       16669    16669           
  Branches     4814     4814           
=======================================
+ Hits        11483    11484    +1     
+ Misses       5153     5152    -1     
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/utils.ts 96.37% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b020f...51a7900. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! should it be a full GitHub link so it works on npmjs.com as well?

@mrienstra
Copy link
Contributor Author

thanks! should it be a full GitHub link so it works on npmjs.com as well?

That doesn't seem to be necessary, I just took a look at https://www.npmjs.com/package/jest-matcher-utils and the link is currently pointing to:
https://github.com/facebook/jest/blob/HEAD/packages/jest-matcher-utils/jest-matcher-utils/src/index.ts
... Which would be fine after the redundant jest-matcher-utils/ is removed by this PR.

Hmm, though maybe it's helpful for other sites:

  1. https://npm.io/package/jest-matcher-utils points to https://github.com/facebook/jest/blob/master/jest-matcher-utils/src/index.ts now which would still be broken even with this PR as-is.
  2. https://snyk.io/advisor/npm-package/jest-matcher-utils#package-footer has the same issue.
  3. https://yarnpkg.com/package/jest-matcher-utils has a similar issue.

Good call @SimenB, just pushed a new commit to change it to a full link.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit 1f813fa into jestjs:main Nov 25, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
@mrienstra mrienstra deleted the patch-1 branch May 3, 2022 20:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants