Updates node-notifier dep of jest-cli to v5 #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelbr
force-pushed
the
node-notifier
branch
from
835bdbe
to
6a157ce
Compare
mikaelbr
force-pushed
the
node-notifier
branch
from
6a157ce
to
152a88a
Compare
This was referenced Jan 27, 2017
Closed
|
I'd definitely be interested in the buttons! |
|
Cool. I'll look into it tomorrow. And see what'll make most sense. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the dependency of
node-notifierto the latest newly releasedv5.0.1.With this change there are a lot fewer dependencies as the built in CLI is removed, and other dependencies are trimmed.
No change in the way it's used in
jest-cli. Tested on macOS and Windows where it works as expected.As an aside:
With the new
node-notifierinput on macOS is possible. Could be possible to add buttons to rerun the tests. Don't know if this is interesting, but something to think about.