fix: normalize path separator for rootDir replacement

CHANGELOG.md

@@ -4,6 +4,8 @@
 
 ### Fixes
 
+- `[jest-config]` fix: normalize path separator for rootDir replacement ([#7814](https://github.com/facebook/jest/pull/7814))
+
 ### Chore & Maintenance
 
 - `[*]`: Setup building, linting and testing of TypeScript ([#7808](https://github.com/facebook/jest/pull/7808))

packages/jest-config/package.json

@@ -23,7 +23,8 @@
     "jest-validate": "^24.0.0",
     "micromatch": "^3.1.10",
     "pretty-format": "^24.0.0",
-    "realpath-native": "^1.0.2"
+    "realpath-native": "^1.0.2",
+    "slash": "^2.0.0"
   },
   "devDependencies":  {
     "@types/babel__core": "^7.0.4",

packages/jest-config/src/__tests__/normalize.test.js

@@ -9,7 +9,6 @@
 import crypto from 'crypto';
 import path from 'path';
 import {escapeStrForRegex} from 'jest-regex-util';
-import normalize from '../normalize';
 import Defaults from '../Defaults';
 
 import {DEFAULT_JS_PATTERN} from '../constants';
@@ -18,6 +17,8 @@ const DEFAULT_CSS_PATTERN = '^.+\\.(css)$';
 
 jest.mock('jest-resolve').mock('path', () => jest.requireActual('path').posix);
 
+let normalize;
+
 let root;
 let expectedPathFooBar;
 let expectedPathFooQux;
@@ -39,6 +40,7 @@ function joinForPattern() {
 }
 
 beforeEach(() => {
+  normalize = require('../normalize').default;
   root = path.resolve('/');
   expectedPathFooBar = path.join(root, 'root', 'path', 'foo', 'bar', 'baz');
   expectedPathFooQux = path.join(root, 'root', 'path', 'foo', 'qux', 'quux');
@@ -924,6 +926,39 @@ describe('moduleDirectories', () => {
       '/root/node_modules',
     ]);
   });
+
+  describe('win32', () => {
+    beforeEach(() => {
+      jest.resetModules();
+      jest.mock('path', () => jest.requireActual('path').win32);
+
+      normalize = require('../normalize').default;
+      require('jest-resolve').findNodeModule = findNodeModule;
+    });
+
+    afterEach(() => {
+      jest.resetModules();
+      jest.mock('path', () => jest.requireActual('path').posix);
+
+      normalize = require('../normalize').default;
+    });
+
+    it('correctly handles globs', () => {
+      const {options} = normalize(
+        {
+          rootDir: '/root',
+          testMatch: [
+            '<rootDir>/test/{TestCasesNormal,StatsTestCases,ConfigTestCases}.test.js',
+          ],
+        },
+        {},
+      );
+
+      expect(options.testMatch).toEqual([
+        '/root/test/{TestCasesNormal,StatsTestCases,ConfigTestCases}.test.js',
+      ]);
+    });
+  });
 });
 
 describe('preset', () => {
@@ -1375,40 +1410,36 @@ describe('testPathPattern', () => {
 
       describe('win32', () => {
         beforeEach(() => {
+          jest.resetModules();
           jest.mock('path', () => jest.requireActual('path').win32);
+          normalize = require('../normalize').default;
           require('jest-resolve').findNodeModule = findNodeModule;
         });
 
         afterEach(() => {
           jest.resetModules();
+          jest.mock('path', () => jest.requireActual('path').posix);
+          normalize = require('../normalize').default;
+          require('jest-resolve').findNodeModule = findNodeModule;
         });
 
         it('preserves any use of "\\"', () => {
           const argv = {[opt.property]: ['a\\b', 'c\\\\d']};
-          const {options} = require('../normalize').default(
-            initialOptions,
-            argv,
-          );
+          const {options} = normalize(initialOptions, argv);
 
           expect(options.testPathPattern).toBe('a\\b|c\\\\d');
         });
 
         it('replaces POSIX path separators', () => {
           const argv = {[opt.property]: ['a/b']};
-          const {options} = require('../normalize').default(
-            initialOptions,
-            argv,
-          );
+          const {options} = normalize(initialOptions, argv);
 
           expect(options.testPathPattern).toBe('a\\\\b');
         });
 
         it('replaces POSIX paths in multiple args', () => {
           const argv = {[opt.property]: ['a/b', 'c/d']};
-          const {options} = require('../normalize').default(
-            initialOptions,
-            argv,
-          );
+          const {options} = normalize(initialOptions, argv);
 
           expect(options.testPathPattern).toBe('a\\\\b|c\\\\d');
         });

packages/jest-config/src/utils.js

@@ -13,6 +13,7 @@ import path from 'path';
 import {ValidationError} from 'jest-validate';
 import Resolver from 'jest-resolve';
 import chalk from 'chalk';
+import slash from 'slash';
 
 type ResolveOptions = {|
   rootDir: string,
@@ -66,9 +67,11 @@ export const replaceRootDirInPath = (
     return filePath;
   }
 
-  return path.resolve(
-    rootDir,
-    path.normalize('./' + filePath.substr('<rootDir>'.length)),
+  return slash(
+    path.resolve(
+      rootDir,
+      path.normalize('./' + filePath.substr('<rootDir>'.length)),
+    ),
   );
 };