Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serdes.Default #95

Merged
merged 6 commits into from
May 4, 2023
Merged

Add Serdes.Default #95

merged 6 commits into from
May 4, 2023

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Apr 28, 2023

Also refactor, pushing the BytesEncoder logic out to 'add' NewtonsoftJson.Serdes.SerializeToUtf8 as advertised in #94

Also refactor to 'add' NewtonsoftJson.Serdes.SerializeToUtf8
@deviousasti
Copy link
Member

This is the only member accessible in Options anyway - we can let static ctor do lazy loading.

    static let def = lazy Options.Create()

    /// <summary>Analogous to <c>JsonSerializerOptions.Default</c> - allows for sharing/caching of the default profile as defined by <c>Options.Create()</c></summary>
    static member Default : JsonSerializerOptions = def.Value

to

    /// <summary>Analogous to <c>JsonSerializerOptions.Default</c> - allows for sharing/caching of the default profile as defined by <c>Options.Create()</c></summary>
    static member val Default = Options.Create()

@bartelink bartelink marked this pull request as ready for review May 4, 2023 11:30
@bartelink bartelink merged commit 3e7ffb0 into master May 4, 2023
@bartelink bartelink deleted the serdes-utf8 branch May 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants