Add Codec support for MemoryStore #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
force-pushed
the
memorystore-envelope
branch
from
7594304
to
0dcd3f0
Compare
bartelink
changed the title
bartelink
force-pushed
the
memorystore-envelope
branch
from
5bcc437
to
c83801e
Compare
bartelink
force-pushed
the
memorystore-envelope
branch
from
c83801e
to
5a8c6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
MemoryStorestores the events directly, as supplied, without any transformations being applied. One downside to this is that it does enable multiple 'aggregates' to share the same data but with different event Types (e.g. if one aggregate has a subset of the union cases of another).This upgrades
MemoryStoreto admit acodecparameter, which makes it equivalent in facilities to the other stores, including support for metadata management.relies on jet/FsCodec#25
related: jet/FsCodec#24