Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Confluent.Kafka 0.11.3 / librdakfa.redist 0.11.4 support #4

Merged
merged 7 commits into from
Jun 17, 2019

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Jun 13, 2019

This provides a source-code compatible version of Propulsion.Kafka that, instead of depending on Jet.ConfluentKafka.FSharp v >= 1.0.1 and Confluent.Kafka 1.0.1:

  • can use Confluent.Kafka 0.11.3 + librdkafka.redist 0.11.4
  • does not depend on Jet.ConfluentKafka.FSharp 0.x

@bartelink bartelink changed the title Add Confluent.Kafka v 0.9.3 support Add Confluent.Kafka 0.11.3 / librdakfa.redist 0.11.4 support Jun 14, 2019
@bartelink bartelink force-pushed the kafka0 branch 2 times, most recently from 1e0a5ee to 79facf3 Compare June 14, 2019 14:25
| null -> ()
| message -> ingest message
with| :? System.OperationCanceledException -> log.Warning("Consuming... cancelled")
| :? ConsumeException as e -> log.Warning(e, "Consuming... exception")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these always the only exceptions that can be thrown by the consumer.Consume function?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for V1; for V0 its a different set. The consumer thread is guarded by a top-level catch which abends the pipeline (and, resultantly, typically the process) if something outside the set is encountered. For V1, I inspected the source, for V0 it makes sense to base this on what equivalent wrappers do - open to ideas...


let runProducers log (broker : Uri) (topic : string) (numProducers : int) (messagesPerProducer : int) = async {
let runProducer (producerId : int) = async {
let cfg = KafkaProducerConfig.Create("panther", broker, Acks.Leader)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a variable and not "panther" or is the test topic panther?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this becomes the client.id and is also used in some ephemeral topic names in the test context (normally with a guid or id to guearantee uniqueness) - it could also be "leopard" or "foo" ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants