Create package evidence using cli #21
Conversation
This reverts commit bf36c53.
evidence/cli/flags.go
Outdated
|
|
||
| // Unique evidence flags | ||
| predicate = "predicate" | ||
| predicateType = "predicate-type" | ||
| subjectRepoPath = "subject-repo-path" | ||
| subjectSha256 = "subject-sha256" | ||
| key = "key" | ||
| keyId = "key-name" | ||
| KeyAlias = "key-alias" |
There was a problem hiding this comment.
No need to export this constant, can be keyAlias.
| "github.com/jfrog/jfrog-client-go/utils/log" | ||
| ) | ||
|
|
||
| const leadArtifactQueryTemplate = `{ |
There was a problem hiding this comment.
Why putting a const if you dont use it as const?
Also, it is used only in one place just copy it to line 124
There was a problem hiding this comment.
i tried to change it, but i think also is not bad to have it private const here since its too long and a bit confusing to have it directly inside the small method.
evidence/cli/command_package.go
Outdated
|
|
||
| func (epc *evidencePackageCommand) validateEvidencePackageContext(ctx *components.Context) error { | ||
| if !ctx.IsFlagSet(packageVersion) || assertValueProvided(ctx, packageVersion) != nil { | ||
| return errorutils.CheckErrorf("'packageVersion' is a mandatory field for creating a Package evidence: --%s", packageVersion) |
There was a problem hiding this comment.
In this command, and also in the existing build/release-bundle commands: we should not log the internal names of the variables - having packageVersion or packageRepoName in the logs is confusing.
Instead, we should mention only those names, which a client is supposed to use, for example:
--%s is a mandatory parameter for creating a Package evidence
evidence/model/graphql.go
Outdated
| @@ -0,0 +1,26 @@ | |||
| package model | |||
|
|
|||
There was a problem hiding this comment.
Sounds like metadata.go and MetadataResponse / PackageVersionsResponse.
(the "graphql" like "REST" is very generic - it can refer to anything)
No description provided.