Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Summary - New UI #2671

Merged
merged 43 commits into from
Sep 1, 2024
Merged

Command Summary - New UI #2671

merged 43 commits into from
Sep 1, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Aug 28, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Loads possible scan results which were recorded in order to display them inside buildInfoSummary

image

@EyalDelarea EyalDelarea marked this pull request as ready for review August 29, 2024 09:55
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 29, 2024
@EyalDelarea EyalDelarea removed the improvement Automatically generated release notes label Aug 29, 2024
@EyalDelarea EyalDelarea changed the title Command Summary - Load possible scan results Command Summary - New UI Aug 29, 2024
@EyalDelarea EyalDelarea added the new feature Automatically generated release notes label Aug 29, 2024
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Aug 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 31, 2024
general/summary/cli.go Outdated Show resolved Hide resolved
general/summary/cli.go Outdated Show resolved Hide resolved
@@ -37,14 +37,13 @@ func (ms MarkdownSection) String() string {
return string(ms)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's the below variable into a const -

var markdownSections = []MarkdownSection{Security, BuildInfo, Upload}

@@ -1829,7 +1829,7 @@ var commandFlags = map[string][]string{
},
Docker: {
buildName, buildNumber, module, Project,
serverId, skipLogin, threads, detailedSummary, watches, repoPath, licenses, xrOutput, fail, ExtendedTable, BypassArchiveLimits, MinSeverity, FixableOnly,
serverId, skipLogin, threads, detailedSummary, watches, repoPath, licenses, xrOutput, fail, ExtendedTable, BypassArchiveLimits, MinSeverity, FixableOnly, vuln,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this flag addition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eyalbe4 we noticed that this flag wasn't passed to JFrog CLI Security, so I added it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 1, 2024
Copy link
Contributor

github-actions bot commented Sep 1, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Sep 1, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 1, 2024
@EyalDelarea EyalDelarea merged commit e0ea860 into jfrog:dev Sep 1, 2024
59 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants