Fix PR comments

jfrog · Jan 7, 2023 · f7068e3 · f7068e3
1 parent 80b6490
commit f7068e3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 NEW FEATURES:
 
-* added validation for the cron expression length to only allow 6-7 characters expressions. PR [#25](https://github.com/jfrog/terraform-provider-shared/pull/25)
+* added validation for the cron expression length to only allow 6-7 parts expressions. PR [#25](https://github.com/jfrog/terraform-provider-shared/pull/25)
 
 ## 1.8.0 (December 21, 2022)
 

diff --git a/validator/validator.go b/validator/validator.go
@@ -48,12 +48,12 @@ func Cron(value interface{}, _ cty.Path) diag.Diagnostics {
 
 func CronLength(value interface{}, _ cty.Path) diag.Diagnostics {
 	var diags diag.Diagnostics
-	cron := regexp.MustCompile("[^\\s]+").FindAllString(value.(string), -1)
+	cron := strings.Split(value.(string), " ")
 
-	if len(cron) > 7 || len(cron) < 6 {
+	if len(cron) < 6 || len(cron) > 7 {
 		diags = append(diags, diag.Diagnostic{
 			Severity: diag.Error,
-			Summary:  "Invalid Cron expression, value should be between 6 and 7 characters long",
+			Summary:  "Invalid Cron expression, value should be between 6 and 7 parts long",
 			Detail:   fmt.Sprintf("%s is not a valid cron", value),
 		})
 	}