Fix splitting cluster on Rolling Update #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaskawi
force-pushed
the
fix_split_during_rolling_upgrade
branch
from
0c37709
to
34427bf
Compare
|
A working demo has been pushed into this repository: https://github.com/slaskawi/jgroups-kube-ping-bcd595949-vr6tw |
rhusar
requested changes
Oct 11, 2019
slaskawi
force-pushed
the
fix_split_during_rolling_upgrade
branch
from
34427bf
to
8b71125
Compare
rhusar
reviewed
Oct 11, 2019
rhusar
requested changes
Oct 11, 2019
rhusar
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes warning message described in #75. It makes sure, all pods use correct group only if
split_clusters_during_rolling_updateis turned on. This warning needs to stay and shouldn't be silenced out.Additionally, this should work fine also with StatefulSets now.
The final change is for
KUBERNETES_SPLIT_CLUSTERS_DURING_ROLLING_UPDATEfunctionality. Starting from now, theKUBE_PINGwill also take not ready Pods into consideration. By default, this option is set totrue.fixes #75
fixes #77