-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] SASS division without slash #3333
Comments
Same here, might be a good idea to run https://github.com/sass/migrator on the Sass files? |
It seems bulma still makes use of It's probably safer to downgrade |
Recommendation: math.div($i, 12) |
Full error example: : Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($button-padding-horizontal, 4)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
88 │ +ltr-property("margin", $button-padding-horizontal / 4)
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
node_modules\bulma\sass\elements\button.sass 88:31 @import
node_modules\bulma\sass\elements\_all.sass 5:9 @import
node_modules\bulma\bulma.sass 5:9 @import
resources\sass\buefy.scss 166:9 @import
stdin 1:9 root stylesheet |
did you manage to resolve this error? |
It seems that this error is preventing anyone from using the latest Bulma via sass. Is there a release date for this? I've had to run Also, I wonder if this issue should be flagged as a bug, not a feature. |
This is explained in https://sass-lang.com/blog/libsass-is-deprecated. Libsass is depreciated and won't get anymore features (this one was one of the reasons for the depreciation). |
From your project's root run this
So patch-package will create a patch until bulma fixes this. Commit the patch file. Check patch-package documentation for it's setup. |
guys, any serious solution from bulma for this? thanks @sajithneyo for the patch option but it is not something I can use in my actual project. |
There is a similar discussion about this with Bootstrap with a range of suggestions: twbs/bootstrap#34051 |
@sajithneyo's comment should work for now if you're using npm or Yarn 1. If you're using Yarn 2, you should use Yarn's built-in yarn patch bulma
yarn dlx sass-migrator division --migrate-deps {PATH TO PATCH FOLDER}
yarn patch-commit {PATH TO PATCH FOLDER} |
Can someone explain the implications of using @sajithneyo's solution? If Bulma rolls out an "official" fix, will it override the patch? Also, I'm assuming this patch won't actually do anything if you're importing individual |
I imagine it'd be the same for Yarn's built in
Actually, the patch only overrides the |
Re patch-package: When a new version of Bulma is released, patch-package will attempt to apply the patch same as before.
If the patch is not needed anymore, you can delete it (it won't be applied anyway). If a new patch is needed, you'd need to re-run the sass migrator and then recreate the patch (the old patch will be overwritten). The whole process is pretty foolproof, we're using patches for a couple of other packages. |
Any other solutions for this? I'm compiling with parcel 2, and its
|
@Rainbowlemon According to https://v2.parceljs.org/languages/sass/ you can configure sass options into sass configuration files and add the quietDeps option from the recent |
If you use dart-sass via module.exports = {
module: {
rules: [
{
test: /\.s[ac]ss$/i,
use: [
"style-loader",
"css-loader",
{
loader: "sass-loader",
options: {
sassOptions: { quietDeps: true } // Add this
}
}
]
}
]
}
}; Or if you use it in export default {
// ...
build: {
loaders: {
scss: { sassOptions: { quietDeps: true } },
sass: { sassOptions: { quietDeps: true } }
}
}
}; |
Is there any solution for using Bulma SASS with Gatsby? So far I keep my SASS dependency pinned to |
I've just created a |
It works now! Thank you! |
Great, work again. |
See issue @ jgthms/bulma#3333 See bugfix PR @ jgthms/bulma#3362
See issue @ jgthms/bulma#3333 See bugfix PR @ jgthms/bulma#3362
This is about Bulma.
Overview of the problem
This is about the Bulma CSS framework
I'm using Bulma version [0.9.2]
This is a Sass issue: I'm using version [1.33.0]
I am sure this issue is not a duplicate
Description
Usage of slash division will be deprecated in sass 2.0.0 and now my console gets polluted with deprecation warnings.
https://sass-lang.com/documentation/breaking-changes/slash-div
Steps to Reproduce
Expected behavior
No warnings.
Actual behavior
Warning for every slash used for division.
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
The text was updated successfully, but these errors were encountered: