Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #1534] Hamburger Menu Now Has 2 Size Classes for Smaller / Larger Scenarios #1535

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Fixes #1534] Hamburger Menu Now Has 2 Size Classes for Smaller / Larger Scenarios #1535

wants to merge 4 commits into from

Conversation

raygervais
Copy link

@raygervais raygervais commented Dec 16, 2017

This is a bugfix which resulted in an improvement.
Fixes #1534

Proposed solution

Fixes the Hamburger responsive concept by adding two new classes is-small and is-large which reduce or expand the dimensions of the hamburger menu spans.

Tradeoffs

No trade offs that I can think of, since this is entirely style-sheet class driven.

Examples in testing.

Testing Done

#1534 contains the final testing, which @jimblue concluded was appropriate for the required bugfix / improvement. @jgthms, if you have any issues with this improvement / bugfix, I'd be happy to correct.

@raygervais raygervais changed the title [Fixes #1534] Hamburger Menu Height Now Dynamic [Fixes #1534] Hamburger Menu Now Has 2 Size Classes for Smaller / Larger Scenarios Dec 28, 2017
@bb010g
Copy link

bb010g commented Dec 31, 2017

Is this blocked on anything?

@raygervais
Copy link
Author

Not that I know of @bb010g, simply waiting for this to be merged in.

@jimblue
Copy link

jimblue commented Feb 22, 2018

hey @jgthms ! Can we have your input on this? Any chance to merge?

@isaackearl
Copy link

this seems to have gotten stale. +1 though

@tulsileathers
Copy link

this is still needed! can we merge it?

@timleachsw
Copy link

Yes, this is a much-needed feature... are there any temporary workarounds we can use to change the burger's size in the meantime?

@rwlnd
Copy link

rwlnd commented Apr 14, 2020

Bumped into this MR because I was looking for a way to increase hamburger size as well. Would be nice if it could still be merged in.

@zlobec
Copy link

zlobec commented Jul 21, 2020

Now this would really be a nice option to have... but in the meantime, i did this... it's ugly and barely works:

.navbar-burger.is-large { transform: scale(2) translateX(-33%); }

@SlothKun
Copy link

any follow up on this ?

@Johng117
Copy link

It would be great if this could be merged.

@maxbbender
Copy link

Now this would really be a nice option to have... but in the meantime, i did this... it's ugly and barely works:

.navbar-burger.is-large { transform: scale(2) translateX(-33%); }

works kinda for me too, like you mentioned barely works.

Would love to have this option as well natively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

burger size is not responsive to navbar height