Add has-bg helpers for block background colors #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am currently doing this thing using the same class pattern suggested. Would love to see this in the framework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement. There has been no simple way to add background colors in an analogous way to the
.has-texthelpers for text color, and this PR adds.has-bghelpers to fix the gap.The CHANGELOG.md has been updated.
Proposed solution
This PR adds
.has-bghelpers which parallel the.has-texthelpers, in order to provide background colors for blocks.Tradeoffs
This is the simplest solution I could come up with, and one that tries to be in line with the
existing helpers for text color.
Testing Done
I have confirmed that block items, such as grid cells, receive the background colors indicated by the helper class.