Fix icons floating out of input area #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the problem of the .has-icon-left / .has-icon-right fields floating out of the input area when a .help element is floated to the right of a preceding input
|
Reproduced with doc example, fixed with @ReeceM bugfix. |
|
@jgthms Thanks for merging the PR 👍. Only looked today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem of the
control has-icon-*icons floating out of the input area when a.helpelementis-pulled-rightof a preceding field.This is a imporvement / bugfix.
There are no similar problems as I don't think anyone has done the layout I used to get the layout error.
Proposed solution
Add
clear: bothto the.controlclass to account forhelpelements being pulled to the right when there are no labels between individual inputs. This sort of layout may be preferred when a minimal form is used. But when the help text is made visible everything goes out of whack.Examples of the problem
Fix Applied
Adding
clear: bothTradeoffs
There are no draw backs from what I can tell. The function is supported since CSS 2.1.
Testing Done
The feature is confirmed to be working across the browsers I have access too.
Latest Safari on Mac, Chrome Mobile, Firefox dev. and Firefox
Can work across all though...
I used the default examples from Bulma documentation to do tests on for creating the error and fixing it. Has been built on the latest release and tested in a development app.