Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #753 #1884

Merged
merged 3 commits into from
May 30, 2018
Merged

Fixes issue #753 #1884

merged 3 commits into from
May 30, 2018

Conversation

mallardduck
Copy link
Contributor

Set navbar hamburger color to match items and allow manual setting

This is a improvement and/or bugfix.

Proposed solution

This patch is a bugfix for #753 and a general improvement to the Navbar. The issue in that PR essentially highlights a gap in the current variables provided with in the Navbar.sass file. This solves that by adding a Sass variable to cover the use case.

In the docs customizing the Navbar color doesn't have this issue as it uses helper classes to set both background-color and color. When you choose to configure the Navbar color via Sass variables though you don't have this ability. Lacking this variable could require extra unnecessary lines of code in comparison to the ease provided by using the variable.

Tradeoffs

Initially I added the variable as a copy-pasta of navbar-item-color. This could be suboptimal though because ideally navbar items and the hamburger should be similar. For example, if you set the navbar-background-color to a dark navyblue and items to to a off white then a black hamburger wouldn't be very visible.

Setting this new variable to default to the navbar-item-color allows for that potential trade-off to be negated. Also, by adding the new variable - instead of simply reusing navbar-item-color - it allows the flexibility set the uniquely if need.

Testing Done

I have tested this feature locally within my own project I'm building with Bulma right now.

Adds a sass variable to control the Navbar's burger color. Sets the default to match what the Item color is set to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants