Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set navbar hamburger color to match items and allow manual setting
This is a improvement and/or bugfix.
Proposed solution
This patch is a bugfix for #753 and a general improvement to the Navbar. The issue in that PR essentially highlights a gap in the current variables provided with in the Navbar.sass file. This solves that by adding a Sass variable to cover the use case.
In the docs customizing the Navbar color doesn't have this issue as it uses helper classes to set both background-color and color. When you choose to configure the Navbar color via Sass variables though you don't have this ability. Lacking this variable could require extra unnecessary lines of code in comparison to the ease provided by using the variable.
Tradeoffs
Initially I added the variable as a copy-pasta of navbar-item-color. This could be suboptimal though because ideally navbar items and the hamburger should be similar. For example, if you set the navbar-background-color to a dark navyblue and items to to a off white then a black hamburger wouldn't be very visible.
Setting this new variable to default to the navbar-item-color allows for that potential trade-off to be negated. Also, by adding the new variable - instead of simply reusing navbar-item-color - it allows the flexibility set the uniquely if need.
Testing Done
I have tested this feature locally within my own project I'm building with Bulma right now.