Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add without-arrow class for navbar items #1919

Merged
merged 3 commits into from
Jun 11, 2018
Merged

Conversation

Ana06
Copy link
Contributor

@Ana06 Ana06 commented Jun 5, 2018

It removes the arrow in the items of the Navbar.

image

Closes #1833.

I have rebuilt the css and updated the documentation and the changelog. However the documentation generated css doesn't seem to include the changes:

Am I missing something? Is it maybe fixed to the current released version and is it ok like that? 🤔

image

@damanwiththeplan
Copy link
Contributor

should be is-arrowless or something to match bulma syntax tho

It removes the arrow in the items of the Navbar.

Closes jgthms#1833
@Ana06
Copy link
Contributor Author

Ana06 commented Jun 7, 2018

@patrickabkarian name changed! 👍

@jgthms is there something else to change? 🤔

@jgthms
Copy link
Owner

jgthms commented Jun 7, 2018

@Ana06 It looks pretty good! I'm gonna take a closer look tomorrow.

@jgthms
Copy link
Owner

jgthms commented Jun 8, 2018

Thanks for writing the documentation and updating the changelog too. Few people actually do it when contributing.

There's only a couple of things to change:

  • can you remove the generated CSS from your PR? These files are only updated in the repo when there's a release, because they're versioned.
  • can you wrap your documentation into a if statement like here? It would prevent website visitors from wondering where the feature is.

Cheers.

@Ana06
Copy link
Contributor Author

Ana06 commented Jun 11, 2018

@jgthms

  • can you remove the generated CSS from your PR? These files are only updated in the repo when there's a release, because they're versioned.
  • can you wrap your documentation into a if statement like here? It would prevent website visitors from wondering where the feature is.

Done! 😉

@jgthms
Copy link
Owner

jgthms commented Jun 11, 2018

Fantastic! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove arrow in Navbar items
3 participants