Add content ol types - fixes #1940 #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add list style modifiers emulating type attribute values different then decimal to ol element in content class - fixes #1940
This is an improvement.
Currently bulma content doesn't support any way of adding semantic ol types in HTML. ol type attribute added in HTML is ignored.
Proposed solution
Add the following modifiers to content ol element:
Tradeoffs
This solutions is easy to use and not coupled to any other element.
It increases build time and complexity minimally.
The performance penalty should also be negligible.
Testing Done
I have created a simple content div with embedded ol element. I tried all classes and the display was correct. Example below.