Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1875 | buttons and tags group sizing (are-small/are-medium/are-large) #2201

Merged
merged 3 commits into from
Oct 31, 2018

Conversation

diomed
Copy link
Contributor

@diomed diomed commented Oct 29, 2018

This is a new feature.
Proposed solution

This patch is a new feature to accommodate the request in #1875. The issue has a request for sizing classes on the the .buttons and .tags elements. This PR adds that feature by adding are-medium and are-large classes to the tag.sass file and are-small, are-medium, and are-large classes to the button.sass file.

Tradeoffs

Using the sizing classes on the .tags or .buttons elements removes the ability to size the children individually. For instance, if you used .are-medium on the parent element and then tried to give one of the children .is-small, it wouldn't apply the .is-small styling.

If the user wishes to have differently sized buttons, they will have to add the desired sizing class to each .button element. This would be no different than how they currently have to size buttons differently.

Testing Done


hijacked pull #1959 from @iamtimsmith (Thank You) - which can be closed now

@jgthms jgthms self-assigned this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants