Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variables for setting background-color thead, tbody, tfoot #2206

Merged
merged 2 commits into from
Oct 31, 2018
Merged

add variables for setting background-color thead, tbody, tfoot #2206

merged 2 commits into from
Oct 31, 2018

Conversation

motionsuggests
Copy link
Contributor

Based off of this discussion #2046 I have an implementation being able to set the background-color for tables using variables.

This is a New feature.

Proposed solution

Fixes #2046

Tradeoffs

  • I'm not sure what issues would be around using background-color: transparent as the default for thead, tbody, tfoot

Testing Done

  • npm run build

I built a sample table using football example from the docs. I tested it using all of the modifiers is-bordered is-striped is-narrow is-hoverable is-fullwidth. I also tested it using the background helper classes on individual <td>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants