Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is-relative helper #2375

Merged
merged 1 commit into from
May 17, 2019
Merged

Add is-relative helper #2375

merged 1 commit into from
May 17, 2019

Conversation

lucperkins
Copy link
Contributor

I've gotten bitten on a few projects where I expected sections to act more like containers, i.e. to set horizontal limits to what's inside of them. This change makes sections have what I take to be more predictable behavior.

@jgthms
Copy link
Owner

jgthms commented Feb 21, 2019

I understand the idea behind this change, but it might break several setups, if users rely on the fact that sections are not positioned, and that they position elements in reference to the body, not the section.

@lucperkins
Copy link
Contributor Author

Ah, okay, that makes sense. I wasn’t fully aware of the range of uses. I’ll modify the PR to include some documentation changes instead.

@micovi
Copy link

micovi commented Mar 9, 2019

How about adding .is-relative helper class that we can use on elements where we need this behavior?

@lucperkins lucperkins changed the title Add position: relative to section Add is-relative helper Mar 14, 2019
@lucperkins
Copy link
Contributor Author

Okay, I've updated this PR to supply an is-relative helper class plus docs. I totally understand if you feel like this either isn't useful or should be part of a larger feature set. If the latter is the case, let me know and I'd be glad to help out.

@jgthms jgthms merged commit ff82799 into jgthms:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants