Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependency on self #124

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Resolve dependency on self #124

merged 1 commit into from
Jan 31, 2024

Conversation

avahoffman
Copy link
Contributor

Ran into the issue of calling ottrpal::render_without_toc which depends on ottrpal::bookdown_path and getting an inscrutable message in github actions. Basically, it's not finding the path.

Going to do a quick test and make sure this works.

@avahoffman
Copy link
Contributor Author

Update: works when I run in test! 🤩

      # Run TOC-less version
      # Rendered content for Leanpub and Coursera is very similar.
      # This job creates a shared scaffold for both.
      - name: Run TOC-less version of render
        id: tocless
        run: Rscript -e "devtools::install_github('jhudsl/ottrpal', ref = remotes::github_pull('124'), upgrade = 'never'); ottrpal::render_without_toc()"
        env:
          GITHUB_PAT: ${{ secrets.gh_pat }}

https://github.com/fhdsl/DaSL_Collection/actions/runs/7714824042

@cansavvy
Copy link
Contributor

Thanks for fixing this and also showing how you tested it!! Seems good to me!

@cansavvy cansavvy merged commit 2e3e866 into main Jan 31, 2024
4 checks passed
@avahoffman avahoffman deleted the avahoffman-patch-2 branch January 31, 2024 03:00
@avahoffman avahoffman restored the avahoffman-patch-2 branch January 31, 2024 03:00
@avahoffman avahoffman deleted the avahoffman-patch-2 branch January 31, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants