Escape CSS identifiers correctly

Fixes #2169

Was allowing ElementSelectorChars instead of CssIdentifierChars to pass unescaped.

CHANGES.md

@@ -6,6 +6,11 @@
 * The form associated elements returned by `FormElement.elements()` now reflect changes made to the DOM, 
   subsequently to the original parse. [2140](https://github.com/jhy/jsoup/issues/2140)
 
+### Bug Fixes
+
+* `Element.cssSelector()` would fail if the element's class contained a `*`
+  character. [2169](https://github.com/jhy/jsoup/issues/2169)
+
 ## 1.18.1 (2024-Jul-10)
 
 ### Improvements

src/main/java/org/jsoup/parser/TokenQueue.java

@@ -302,7 +302,7 @@ public static String escapeCssIdentifier(String in) {
         StringBuilder out = StringUtil.borrowBuilder();
         TokenQueue q = new TokenQueue(in);
         while (!q.isEmpty()) {
-            if (q.matchesCssIdentifier(ElementSelectorChars)) {
+            if (q.matchesCssIdentifier(CssIdentifierChars)) {
                 out.append(q.consume());
             } else {
                 out.append(ESC).append(q.consume());

src/test/java/org/jsoup/nodes/ElementTest.java

@@ -2636,6 +2636,18 @@ void prettySerializationRoundTrips(Document.OutputSettings settings) {
         assertEquals(selected.first(), div);
     }
 
+    @Test void cssSelectorWithAstrix() {
+        // https://github.com/jhy/jsoup/issues/2169
+        Document doc = Jsoup.parse("<div class='vds-items_flex-end [&amp;_>_*:first-child]:vds-pt_0'>One</div><div class='vds-items_flex-end'>Two</div>");
+        Element div = doc.expectFirst("div");
+        String selector = div.cssSelector();
+        assertEquals("html > body > div.vds-items_flex-end.\\[\\&_\\>_\\*\\:first-child\\]\\:vds-pt_0", selector);
+
+        Elements selected = doc.select(selector);
+        assertEquals(1, selected.size());
+        assertEquals(selected.first(), div);
+    }
+
     @Test void orphanSiblings() {
         Element el = new Element("div");
         assertEquals(0, el.siblingElements().size());