Add StringUtil.joining() and use in Element.cssSelectorComponent()
#1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Stream
branch
2 times, most recently
from
77acc7e
to
bfccd32
Compare
Isira-Seneviratne
force-pushed
the
Stream
branch
from
bfccd32
to
c73befd
Compare
|
While this is a bit neater, I prefer the current version because it recycles in-use StringBuilders, vs allocating a new one every time. As this method gets called via Perhaps modify the StringUtil to implement a Collectors.joining that uses recycled builders? |
Isira-Seneviratne
force-pushed
the
Stream
branch
from
26f58a5
to
00ad0c7
Compare
# Conflicts: # pom.xml
Isira-Seneviratne
force-pushed
the
Stream
branch
from
5502bcf
to
13e0e95
Compare
jhy
reviewed
Dec 29, 2023
| @@ -5,11 +5,14 @@ | |||
|
|
|||
| import java.net.MalformedURLException; | |||
| import java.net.URL; | |||
| import java.util.Arrays; | |||
| import java.util.Collection; | |||
| import java.util.Iterator; | |||
There was a problem hiding this comment.
Can you change your format settings so that we don't use wildcard imports? Prefer to list them all explicitly.
jhy
changed the title
StringUtil.joining() and use in Element.cssSelectorComponent()
|
Thanks, merged! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncomment the
streamblock inElementand make some improvements to it.