Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some exports to move towards more ESM compatibility #1154

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Change some exports to move towards more ESM compatibility #1154

merged 1 commit into from
Feb 5, 2023

Conversation

danielholmes
Copy link
Collaborator

What's Changing and Why

There's some parts of the source code that still use commonJS export style. This change makes a more consistent code base and once completely done, open opportunities to simplify and improve the compile steps (babel, browserify, etc).

Note: There are still 1 locations with CJS exports, one i being handled in another PR, the other is the core requests module which requires a larger discussion (PR forthcoming).

What else might be affected

It's a pretty simple change. The tests run for me and I can't imagine it breaking anything

Tasks

  • Add tests
  • Update Documentation
  • Update jimp.d.ts
  • Add SemVer Label

@hipstersmoothie
Copy link
Collaborator

Hmm I don't know what the actions aren't running

@hipstersmoothie hipstersmoothie merged commit b6f1e35 into jimp-dev:master Feb 5, 2023
@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Feb 5, 2023
@danielholmes
Copy link
Collaborator Author

@hipstersmoothie I found some discussion about this in the actions/checkout repo:

actions/checkout#298

One suggested fix is:

token: ${{ secrets.MY_TOKEN || github.token }}

in the workflow

@hipstersmoothie
Copy link
Collaborator

ah. I'm not sure that line was necessary. If it is thanks for the heads up!

@hipstersmoothie
Copy link
Collaborator

These other failures are for the canary release. I want to make running that part something I can opt into via label or something. So for now it will only work for people with access to the repo

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

🚀 PR was released in v0.21.3 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants