Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#35 - Added support for encrypted assertions. #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Havagan
Copy link

@Havagan Havagan commented Aug 26, 2023

  • Added support for encrypted assertions.
  • Added Shouldly for unit test assertions.

@alex-jitbit
Copy link
Member

Thanks! Would you mind switching spaces to tabs? Makes it really hard to diff-review.

PS. I like Shoudly, also switching to ClaimtTypes constants vs hardcoded strings is also nice

@Havagan
Copy link
Author

Havagan commented Aug 27, 2023

Thanks! Would you mind switching spaces to tabs? Makes it really hard to diff-review.

Yep, I should have time to do that tomorrow and resubmit.

I didn't notice on my diff while creating the PR because I have it set to "hide whitespace" differences.

image

…ows file encoding.

jitbit#35 - Added support for encrypted assertions.
@Havagan
Copy link
Author

Havagan commented Aug 30, 2023

@alex-jitbit

Would you mind switching spaces to tabs? Makes it really hard to diff-review.

How do you want to handle these whitespace differences?

I confirmed that I use tabs and not spaces, but there were differences in file encoding and line endings.

  • Encoding: you look to be using Western Europen Windows while I was UTF-8.
  • Endings: you look to be using mostly LF while I was using CRLF.

To fix this, I added an editorconfig and set those values to match yours.

end_of_line = lf
insert_final_newline = true
indent_style = tab
indent_size = 4
tab_width = 4
charset = Windows-1252 # Western European Windows

After those changes, there still was a lot of whitespace differences on compare and I think it's due to inconsistent line endings. The editor config is now forcing LF but the original .cs files have a mix of LF and CRLF.

LineEndings01
LineEndings02

@alex-jitbit
Copy link
Member

no worries, I'll take it form here and modify your branch accordingly before merging (hope you have "allowed changes form maintainers" settings enabled for the PR :))

@carlo318
Copy link

Hello, this pull request could be very useful, for a project I am working on, and I could test it.
I see there is still a branch conflict, are you going to solve it?
Thankyou :-)

@carlo318
Copy link

carlo318 commented Dec 28, 2023

Hi @Havagan, can you please provide an example on how to handle the Encrypted Assertions?
I see that there is GetEncryptedAttributes() but I get no attributes. Maybe I am doing it wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants