Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DTEND, data types, and zoneless local date and date-time values #421

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

simonratner
Copy link

@simonratner simonratner commented Sep 25, 2020

This change adds:

  • Support for DTEND (no duration concept, just validate and round-trip it) (DTEND seems to be an invalid property #322)
  • Support for VALUE=DATE | DATE-TIME data types on DTSTART, DTEND, and UNTIL attributes
  • Proper parsing and handling of zoneless local time values (they are stored without a tz specifier, instead of assuming UTC, and are round-tripped without the trailing Z suffix, as per RFC)

Because of this last change to tzid handling, this is a breaking change, but it implements zoneless values much closer to the RFC.


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised

@simonratner simonratner changed the title Add support for DTEND, DTVALUE, and zoneless local date and date-time values Add support for DTEND, data types, and zoneless local date and date-time values Sep 25, 2020
@andjiev
Copy link

andjiev commented Sep 28, 2020

@jakubroztocil Can this be merged?

@Nuranto
Copy link

Nuranto commented Nov 18, 2020

I also need this. Tried to build it but I can't manage to do it. (I'm not familiar with yarn/ts)
Could you merge it, or can someone explain how to build this ? (I have errors like Can't resolve 'ts-loader' or Error: Can't resolve 'source-map-loader'...)

@simonratner
Copy link
Author

can someone explain how to build this

This works for me after setting target: es6 in tsconfig.json:

yarn install
yarn test
yarn run build

Find the output in dist/ directory afterwards.

@ratheep
Copy link

ratheep commented Mar 14, 2021

@simonratner , @jakubroztocil Wondering why this isn't yet merged with master ?

@georgiosgiatsidis
Copy link

Is this PR about to be merged?

@gazben
Copy link

gazben commented Feb 28, 2022

@jakubroztocil Can you merge this?

@KrisLau
Copy link

KrisLau commented Mar 18, 2022

@davidgoli

@frozencap
Copy link

damn. 3 year old PR implementing multiple highly-awaited features, doesn't receive a single comment from the maintainers :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants