Fixes use restricted data token on unrestricted report documents #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Any middleware applied to an endpoint that is specified in the restricted.json or grantless.json resource files must invoke the relevant RDT/Grantless middleware itself, since those middlewares will no longer be automatically applied * Invoke RestrictedDataToken middleware from RestrictedReport middleware, instead of applying both middlewares to the GetReportDocument request class * Remove restricted report check from GetReportDocument class since it is autogenerated * Safety checks in DownloadsDocument when looking for the document type in JSON files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to solve issue: #671