Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Cmd on Windows #976

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

puskarpeter
Copy link
Contributor

  • attempts to switch from GitBash that has underlying slow IO operations

@puskarpeter
Copy link
Contributor Author

Seems like this is not helping at all, since maybe the underlying process in the runner which spawns the run command is using GitBash (it builds slow when I open gitbash, then run cmd, and then inside there I build). Something strange is going on here.

@puskarpeter
Copy link
Contributor Author

I think I figured it out, it was the PATH env variable leaking from the gitbash parent process.
Hopefully this should resolve the issue as after doing this in my VM it solved the problem.

@puskarpeter
Copy link
Contributor Author

That's weird that it is still taking so long, this was enough on the VM to fix the problem

@puskarpeter
Copy link
Contributor Author

We can try to print env before and after refresh to see what's changed and why it does not work here.

@puskarpeter puskarpeter marked this pull request as draft April 26, 2024 12:12
- use mvnw.cmd script on Windows
- clean PATH since MinGW stuff causes slowdown problems
@puskarpeter puskarpeter marked this pull request as ready for review April 26, 2024 13:02
@puskarpeter puskarpeter changed the title Build with PowerShell on Windows Build with Cmd on Windows Apr 26, 2024
@puskarpeter
Copy link
Contributor Author

https://github.com/puskarpeter/jline3/actions/runs/8848691008/job/24299004431

Here passing run in normal time.

Something in the PATH caused trouble, hence we clear it and only put necessary stuff on the PATH:
powershell for the wrapper script and JAVA_HOME for maven

@gnodet
Copy link
Member

gnodet commented Jun 7, 2024

Thx a ton !

@gnodet gnodet merged commit 219dada into jline:master Jun 7, 2024
4 checks passed
@gnodet gnodet added this to the 3.26.2 milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants