#55 revert value switch on flag

jmbarbone · Apr 29, 2023 · 40c10f1 · 40c10f1
1 parent 2895f42
commit 40c10f1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/R/arg.R b/R/arg.R
@@ -349,11 +349,6 @@ arg_parse_value <- function(self, ca) {
     },
     flag = {
       value <- !grepl("^--?no-", ca_get_working(ca)[m + off])
-
-      if (value) {
-        value <- !self$get_default()
-      }
-
       ca_remove_working(ca, m)
     }
   )

diff --git a/tests/testthat/test-class-args.R b/tests/testthat/test-class-args.R
@@ -104,6 +104,11 @@ test_that("action = 'flag' allows TRUE [#55]", {
 
   ca$set_input("--foo")
   obj <- ca$parse()
+  exp <- list(foo = TRUE)
+  expect_identical(obj, exp)
+
+  ca$set_input("--no-foo")
+  obj <- ca$parse()
   exp <- list(foo = FALSE)
   expect_identical(obj, exp)
 })