This repository has been archived by the owner on Feb 4, 2023. It is now read-only.
androdeb: add androdeb pull command #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelagnel
suggested changes
Jun 20, 2018
androdeb
Outdated
| ########################################################## | ||
| # GIT-PULL | ||
| ########################################################## | ||
|
|
There was a problem hiding this comment.
Lose these extra new lines, and comments. Lets keep it as small a change as possible. The code is self-documenting.
androdeb
Outdated
| exit 0 | ||
| fi | ||
|
|
||
|
|
androdeb
Outdated
| @@ -95,6 +127,7 @@ if [ ! -z ${ASHELL+x} ]; then | |||
| exit 0 | |||
| fi | |||
|
|
|||
|
|
|||
| ########################################################## | |||
androdeb
Outdated
| shift || true | ||
| fi | ||
|
|
||
| if [ "2" -le "$#" ]; then |
There was a problem hiding this comment.
I need to check if 2 or more arguments are remaining (multiple files / local destination specified), I guess it could be:
if [$# -gt 1 ]
androdeb
Outdated
| done | ||
| else | ||
| FILES["0"]=/data/androdeb/debian/$1 | ||
| shift || true |
There was a problem hiding this comment.
I need to consume the argument because the last argument (local destination) is passed through below
|
Joel, I refactored the function to make it easier to understand and got rid of the extra lines. Mind taking a look? |
There was already "androdeb pull" command, which did a git pull. This was renamed to "androdeb git-pull". The new command makes it easier to retrieve files from the androdeb filesystem. The same options as "adb pull" are supported. Signed-off-by: Erick Reyes <erickreyes@google.com>
joelagnel
approved these changes
Jun 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already "androdeb pull" command, which did a git pull. This was renamed to "androdeb git-pull". The new command makes it easier to retrieve files from the androdeb filesystem. The same options as "adb pull" are supported.