Add release metadata and display #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the file contents clearer by renaming the file as well.
- Space added for the release name on the now playing display - bump build and version - Added releaseName accessor to RadioStation; parses raw metadata since Fethi's override doesn't work as desired - NowPlayingViewController sets the release on the now playing screen if provided - Add the release name to sharing data if it's available - Fix the "now playing" background to be that nice "cement" color like the rest of the interface
The "next show" times are wrong, so they can't be used as the backup to fix the lag.
If the default mail app isn't configured, the call to see if it is will fail. We want to force-open the mailto: URL if that is the case. - add a new function, bruteForceSendMail, that does this - change openEmail to call it if viewController.canSendMail returns false. Also commit the expansded background so that the app looks right on iPad and MacOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the release field to Now Playing and adds the necessary support methods to parse this out of the metadata and make it available. Also fixes the Now Playing background looking different from the rest of the app.