Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally disable injection of piwik script #33

Merged
merged 3 commits into from
May 12, 2017
Merged

Optionally disable injection of piwik script #33

merged 3 commits into from
May 12, 2017

Conversation

tbtz
Copy link
Contributor

@tbtz tbtz commented May 11, 2017

Added an option to disable the injection of the piwik.js script into DOM.
Also added tests for the option.
Default: Injection enabled.

CAUSES:

We need to load the script separately to:

  • prevent uncontrollable side effects
  • prevent multiple loading if script already exists
  • make loading of the script configurable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c9daab1 on tbtz:optional-piwik-injection into 2510ae2 on joernroeder:master.

@joernroeder
Copy link
Owner

thanks for submitting your idea, code and tests 👍. Would you mind adding the option to the documentation as well. I'll merge it into master afterwards.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling cf26eec on tbtz:optional-piwik-injection into 2510ae2 on joernroeder:master.

@tbtz
Copy link
Contributor Author

tbtz commented May 12, 2017

Added the option to the documentation 😊👍

@joernroeder joernroeder merged commit 9567420 into joernroeder:master May 12, 2017
@joernroeder
Copy link
Owner

thanks for your contribution. i've pushed a new 0.8.2 version to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants