Add Separate Indian male and female names #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update last_names
Update/person
|
@fcurella any ideas how to fix mypy issues? |
|
If we check the
|
wh0th3h3llam1
force-pushed
the
fix-locale-IN
branch
from
2a7f623
to
097db94
Compare
fcurella
requested changes
Aug 12, 2024
wh0th3h3llam1
commented
Aug 18, 2024
fcurella
approved these changes
Aug 21, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Add Separate Indian male and female names
What was wrong
There was no separate male and female names list for locale
en-INHow this fixes it
Add separate list for male and female first names
Fixes #2073