Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add providers vi_VN ( Viet Nam ) #2076

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

ntd1683
Copy link
Contributor

@ntd1683 ntd1683 commented Jul 26, 2024

What does this change

Adds Vietnamese language support (vi_VN) with providers for address, color, company, currency, date_time, job, lorem, person, and phone.

What was wrong

The project lacked support for the Vietnamese locale, limiting its ability to generate localized data.

How this fixes it

Introduces Vietnamese-specific data for address, color, company, currency, date_time, job, lorem, person, and phone.

Fixes #2075

@ntd1683
Copy link
Contributor Author

ntd1683 commented Jul 27, 2024

@joke2k I have added the Vietnamese language, I checked it but there is an error due to your old code. I hope you can look and approve, I see you don't have Vietnamese yet.

@stefan6419846
Copy link
Contributor

The typing failures have already been discussed in another PR. Apart from this, could you please add some source indicators for the new data?

@ntd1683
Copy link
Contributor Author

ntd1683 commented Jul 27, 2024

Các lỗi đánh máy đã được thảo luận trong một PR khác. Ngoài ra, bạn có thể vui lòng thêm một số chỉ số nguồn cho dữ liệu mới không?

ok I will add the source right away

@ntd1683 ntd1683 requested a review from fcurella August 14, 2024 05:16
@ntd1683
Copy link
Contributor Author

ntd1683 commented Aug 21, 2024

@fcurella Hello, do I need to edit anything else to contribute to your project? Because I see that in my country, many people use your products

@fcurella fcurella merged commit c666fab into joke2k:master Aug 21, 2024
28 checks passed
@ntd1683 ntd1683 deleted the add/vi-language-support branch August 23, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Provider for vi_VN (Vietnamese)
3 participants