Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pakistani names Class #2083

Merged
merged 8 commits into from
Aug 21, 2024
Merged

Pakistani names Class #2083

merged 8 commits into from
Aug 21, 2024

Conversation

c2-tlhah
Copy link
Contributor

@c2-tlhah c2-tlhah commented Aug 8, 2024

What does this change

I have added names of pakistani people
Brief summary of the changes.
Created a new file having class for pakistani names

What was wrong

NA
Description of the root cause of the issue.
NA

How this fixes it

NA
Description of how the changes fix the issue.
NA
Fixes #...
NA

@c2-tlhah c2-tlhah closed this Aug 8, 2024
@c2-tlhah c2-tlhah reopened this Aug 8, 2024
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for the new provider?

@c2-tlhah
Copy link
Contributor Author

Can you add a test for the new provider?
< Done

@fcurella fcurella merged commit 8a1e4aa into joke2k:master Aug 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants