Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect City Spelling in uk_UA locale #2084

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

ch4zzy
Copy link
Contributor

@ch4zzy ch4zzy commented Aug 10, 2024

What does this change

The names of the following cities have been changed:

  • Zaporizhia
  • Odessa
  • Khmelnytsky
  • Kiev
  • Uzhgorod
  • Zaporozhye

What was wrong

The current city names are not responding internationally recognized spelling.
Wiki list of cities in Ukraine with correct spelling.
Wiki list of administrative divisions in Ukraine with correct spelling.

How this fixes it

  • Zaporizhia -> Zaporizhzhia
  • Odessa -> Odesa
  • Khmelnytsky -> Khmelnytskyi
  • Kiev -> Kyiv
  • Uzhgorod -> Uzhhorod
  • Zaporozhye -> Zaporizhzhia

faker/providers/date_time/__init__.py Outdated Show resolved Hide resolved
faker/providers/date_time/__init__.py Outdated Show resolved Hide resolved
@ch4zzy ch4zzy requested a review from fcurella August 23, 2024 06:40
faker/providers/date_time/__init__.py Outdated Show resolved Hide resolved
faker/providers/date_time/__init__.py Outdated Show resolved Hide resolved
@ch4zzy ch4zzy requested a review from fcurella August 25, 2024 14:56
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 93ffa73 into joke2k:master Aug 30, 2024
28 checks passed
@ghostishev
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants